hboutemy commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r429610661
##########
File path: pom.xml
##########
@@ -64,6 +64,7 @@
<maven.wagon.http.retryHandler.class>standard</maven.wagon.http.retryHandler.class>
<!-- Try at most 6 times to deploy every artifact -->
<maven.wagon.http.retryHandler.count>6</maven.wagon.http.retryHandler.count>
+
<project.build.outputTimestamp>2020-05-17T18:04:00Z</project.build.outputTimestamp>
Review comment:
> What are the advantages of explicitly setting the timestamp in this
change?
it is also auto-generated (by maven-release-plugin), basically stored in
pom.xml
the advantage is just to remove one additional plugin that does runtime
magic with just a simple property updated during release
theoryinpractice just did a workaround early, before maven-release-plugin
3.0.0-M1 was ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
