aharui commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r429684998
##########
File path: pom.xml
##########
@@ -340,24 +341,6 @@
</executions>
</plugin>
- <!-- This plugin cleans up the jars for anything that might cause
problems for reproducible builds -->
- <!--
- Even if the core maven plugins currently would support doing this
without, we would be required
- to set the line-separator and the Antlr3 plugin crashes if this is set
to something non-default
- -->
- <plugin>
- <groupId>io.github.zlika</groupId>
- <artifactId>reproducible-build-maven-plugin</artifactId>
- <version>0.11</version>
- <executions>
- <execution>
- <goals>
- <goal>strip-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<!-- Plugin to detect problems with JDK incompatibilities -->
Review comment:
We have a Windows CI server that builds the artifacts and the 10 jars we
care about exactly match on my Mac, but we only verify the actual jar and not
the -sources.jar or the source-release.zip. In your "ko" list, you list two
"actual" jars (compiler-0.9.7.jar, debugger-0.9.7.jar).
We do not support Linux at this time, so none of us have tried to verify
that Linux matches Win or OSX. But if you can provide more detail as to what
the differences are in those two jars I would find that interesting. You filed
another issue that made me wonder if you are starting from the right sources.
There is a dependency on a jar that helps order output
`<compiler-build-tools.version>1.2.0</compiler-build-tools.version>`. The
older 1.1.0 version does not guarantee order. And we might still have bugs.
All of the recent bugs have had to do with iterator order when iterating
through a Java HashMap. We have not systematically gone and visited every
HashMap in the code to enforce order on it, we just fix them as we find them.
I guess I'll try to find time to test without zlika, but they specifically
solved one problem for us so we might still need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
