HoustonPutman commented on code in PR #1179:
URL: https://github.com/apache/solr/pull/1179#discussion_r1022989858
##########
solr/server/build.gradle:
##########
@@ -113,11 +116,12 @@ task assemblePackaging(type: Sync) {
include "README.md"
})
- from(configurations.libExt, {
+ // Add in the intersection of serverLib and solrCore
+ from(configurations.libExt + (configurations.serverLib -
(configurations.serverLib - configurations.solrCore)), {
Review Comment:
Yeah its not great. I wish there was better syntax for doing an
intersection. Maybe my gradle googling just isn't good enough.
But if we subtract (the things in serverLib that aren't in solrCore) for
serverLib, that gives us an intersection between serverLib and solrCore. This
is the actual de-duplication of jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
