risdenk commented on code in PR #1179:
URL: https://github.com/apache/solr/pull/1179#discussion_r1023044386
##########
solr/server/build.gradle:
##########
@@ -113,11 +116,12 @@ task assemblePackaging(type: Sync) {
include "README.md"
})
- from(configurations.libExt, {
+ // Add in the intersection of serverLib and solrCore
+ from(configurations.libExt + (configurations.serverLib -
(configurations.serverLib - configurations.solrCore)), {
Review Comment:
Alright so I really must be missing something.
`configurations.libExt + (configurations.serverLib -
(configurations.serverLib - configurations.solrCore))`
I think this is simplifying to:
`configurations.libExt - configurations.solrCore`
I feel like `configurations.libExt + (configurations.serverLib -
configurations.solrCore)` would be all that is needed? I don't understand the
additional `configurations.serverLib` subtraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
