HoustonPutman commented on code in PR #1179: URL: https://github.com/apache/solr/pull/1179#discussion_r1023029097
########## solr/server/contexts/solr-jetty-context.xml: ########## @@ -5,4 +5,19 @@ <Set name="war"><Property name="jetty.base"/>/solr-webapp/webapp</Set> <Set name="defaultsDescriptor"><Property name="jetty.base"/>/etc/webdefault.xml</Set> <Set name="extractWAR">false</Set> + <Set name="parentLoaderPriority">true</Set> + <Call name="addServerClassMatcher"> + <Arg> + <New id="removeServerClasses" class="org.eclipse.jetty.webapp.ClassMatcher"> Review Comment: > RE classpath separation (Jetty vs web app), note there is a nasty line in bin/solr when SOLR_SSL_ENABLED: I have a sneaking suspicion that isn't necessary, at least anymore. We should try to tackle that in a separate PR though. Would like to not have to test SSL at the same time 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
