HoustonPutman commented on code in PR #1179:
URL: https://github.com/apache/solr/pull/1179#discussion_r1023087409
##########
solr/server/build.gradle:
##########
@@ -113,11 +116,12 @@ task assemblePackaging(type: Sync) {
include "README.md"
})
- from(configurations.libExt, {
+ // Add in the intersection of serverLib and solrCore
+ from(configurations.libExt + (configurations.serverLib -
(configurations.serverLib - configurations.solrCore)), {
Review Comment:
This is set math, not arithmetic, so you can't just simplify and remove the
parentheses.
1. `(configurations.serverLib - configurations.solrCore)`: This gets the set
of `serverLib` jars that are not in `solrCore`
1. `(configurations.serverLib - #1)`: This removes the (set of `serverLib`
jars that are not in `solrCore`) from all `serverLib` jars. Therefore we are
left with the set of `serverLib` jars that are **not not** (double-negation) in
`solrCore` => the set of `serverLib` jars that are in `solrCore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
