dsmiley commented on code in PR #1179:
URL: https://github.com/apache/solr/pull/1179#discussion_r1023018665
##########
solr/server/contexts/solr-jetty-context.xml:
##########
@@ -5,4 +5,19 @@
<Set name="war"><Property name="jetty.base"/>/solr-webapp/webapp</Set>
<Set name="defaultsDescriptor"><Property
name="jetty.base"/>/etc/webdefault.xml</Set>
<Set name="extractWAR">false</Set>
+ <Set name="parentLoaderPriority">true</Set>
+ <Call name="addServerClassMatcher">
+ <Arg>
+ <New id="removeServerClasses"
class="org.eclipse.jetty.webapp.ClassMatcher">
Review Comment:
Thanks for that explanation; please add a summary as a comment in the XML.
I definitely prefer a solution (like this) that avoids duplicate JARs; I
didn't know we were doing that (yuck!).
RE classpath separation (Jetty vs web app), note there is a nasty line in
bin/solr when SOLR_SSL_ENABLED:
```
SOLR_JETTY_CONFIG+=("--module=https"
"--lib=$DEFAULT_SERVER_DIR/solr-webapp/webapp/WEB-INF/lib/*")
```
I recall the original introduction of this was by @markrmiller when I did
git history analysis some time ago. I feel we should either not do that, or
just give up on the separation -- this is a single-web app server so why
separate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
