risdenk commented on code in PR #1179:
URL: https://github.com/apache/solr/pull/1179#discussion_r1024311100
##########
solr/server/build.gradle:
##########
@@ -113,11 +116,12 @@ task assemblePackaging(type: Sync) {
include "README.md"
})
- from(configurations.libExt, {
+ // Add in the intersection of serverLib and solrCore
+ from(configurations.libExt + (configurations.serverLib -
(configurations.serverLib - configurations.solrCore)), {
Review Comment:
well since I was not 100% sure. Let me try to work out an example:
* `libExt` = `(a b c)`
* `serverLib` = `(c d e)`
* `solrCore` = `(e f g)`
Taking inner parenthesis first: `(configurations.serverLib -
configurations.solrCore)`
`(c d e) - (e f g)` = `(c d)`
then next parenthesis: `(configurations.serverLib - result)`
`(c d e) - (c d)` = `(e)`
then final addition: `(configurations.libExt + result)`
`(a b c) + (e)` = `(a b c e)`
So as far as I can tell this matches @HoustonPutman explanation. The set of
jars that are in both `solrCore` and `serverLib` added to `libExt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
