serhiy-bzhezytskyy commented on code in PR #4762:
URL: https://github.com/apache/solr/pull/4762#discussion_r3823077090
##########
solr/core/src/test/org/apache/solr/cloud/OverseerTest.java:
##########
@@ -1808,7 +1808,7 @@ private SolrCloudManager
getCloudDataProvider(ZkStateReader zkStateReader) {
solrClients.add(cloudSolrClient);
solrClients.add(httpSolrClient);
SolrClientCloudManager sccm = new SolrClientCloudManager(cloudSolrClient,
null);
- sccm.getClusterStateProvider().connect();
+ sccm.getClusterStateProvider().getLiveNodes();
Review Comment:
Not needed -- the injected `ZkStateReader` constructor stores the reference
directly, no lazy connect to force. Removed and verified with all 4 tests that
exercise this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
