dsmiley commented on code in PR #4762:
URL: https://github.com/apache/solr/pull/4762#discussion_r3822058726
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -692,6 +692,15 @@ public CloudSolrClient newSolrClient(String collection) {
.build(); // we choose 90 because we run in some harsh envs
}
+ /**
+ * Returns a new {@link
org.apache.solr.client.solrj.impl.CloudSolrClient.Builder} pointed at this
+ * cluster's ZooKeeper ensemble, to customize further (default collection,
update routing, HTTP
Review Comment:
don't overdocument implementations details (AI does this all the time).
This is an implementation detail that I plan to change to pick randomly between
the ZK & HTTP ClusterState at some point.
##########
solr/core/src/test/org/apache/solr/cloud/CreateRoutedAliasTest.java:
##########
@@ -545,7 +545,7 @@ private void assertFailure(Request req, String
expectedErrorSubstring) throws IO
}
private void assertCollectionExists(String name) {
- solrClient.getClusterStateProvider().connect(); // TODO get rid of this
+ solrClient.getClusterStateProvider().getLiveNodes(); // TODO get rid of
this
Review Comment:
Your comment/investigation
https://github.com/apache/solr/pull/4762#discussion_r3820874330 nicely confirms
you can remove this
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -692,6 +692,15 @@ public CloudSolrClient newSolrClient(String collection) {
.build(); // we choose 90 because we run in some harsh envs
}
+ /**
+ * Returns a new {@link
org.apache.solr.client.solrj.impl.CloudSolrClient.Builder} pointed at this
+ * cluster's ZooKeeper ensemble, to customize further (default collection,
update routing, HTTP
+ * client, ...) before calling {@code build()}.
+ */
+ public CloudSolrClient.Builder getSolrClientBuilder() {
Review Comment:
rename to `newSolrClientBuilder`; we aren't returning something we already
have.
##########
changelog/unreleased/SOLR-18380-remove-cloudsolrclient-connect-and-legacy-builder.yml:
##########
Review Comment:
Just to share that I sometimes lean in favor of a CHANGELOG -- I think this
is a good one CC @janhoy so you notice ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
