dsmiley commented on code in PR #4778:
URL: https://github.com/apache/solr/pull/4778#discussion_r3857255713
##########
solr/core/src/test/org/apache/solr/cloud/CloudExitableDirectoryReaderTest.java:
##########
@@ -81,7 +82,9 @@ public static void setupCluster() throws Exception {
clusterBuilder.configure();
// pick an arbitrary node to use for our requests
- client = cluster.getRandomJetty(random()).newClient();
+ client =
+ new
HttpJettySolrClient.Builder(cluster.getRandomJetty(random()).getBaseUrl().toString())
Review Comment:
can be newSolrClient on the jetty
##########
solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java:
##########
@@ -300,7 +301,8 @@ public void testCloudInfoInCoreStatus() throws IOException,
SolrServerException
String corename = response._getStr(asList("success", nodeName, "core"),
null);
try (SolrClient coreClient =
-
getHttpSolrClient(cluster.getZkStateReader().getBaseUrlForNodeName(nodeName))) {
+ new
HttpJettySolrClient.Builder(cluster.getZkStateReader().getBaseUrlForNodeName(nodeName))
Review Comment:
Can I convince you to add MiniSolrCloudCluster.getJetty(nodeNameOrUrl)?
Then you'd call it here with getSolrClient(); no need to close.
##########
solr/core/src/test/org/apache/solr/cloud/DistribDocExpirationUpdateProcessorTest.java:
##########
@@ -288,7 +289,10 @@ private Map<String, ReplicaData>
getTestDataForAllReplicas()
for (Replica replica : collectionState.getReplicas()) {
String coreName = replica.getCoreName();
- try (SolrClient client = getHttpSolrClient(replica)) {
+ try (SolrClient client =
Review Comment:
Can I convince you to add a MiniSolrCloudCluster.getSolrClient(Replica)
method that lookups up the right Jetty (see getReplicaJetty)... and then calls
getSolrClient() on it and then wraps that with CollectionScopedSolrClient for
the core?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
