serhiy-bzhezytskyy commented on code in PR #4778:
URL: https://github.com/apache/solr/pull/4778#discussion_r3854379365
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/ConcurrentDeleteAndCreateCollectionTest.java:
##########
@@ -68,7 +69,7 @@ public void testConcurrentCreateAndDeleteDoesNotFail() throws
IOException {
final String collectionName = "collection" + i;
solrCluster.uploadConfigSet(configset("configset-2"), collectionName);
final String baseUrl =
solrCluster.getJettySolrRunners().get(0).getBaseUrl().toString();
- final SolrClient solrClient = getHttpSolrClient(baseUrl);
+ final SolrClient solrClient = new
HttpJettySolrClient.Builder(baseUrl).build();
Review Comment:
Done — applied everywhere a runner was in scope. Two helper methods took
`baseUrl` as a bare `String` param
(`SolrJMetricTestUtils.getNumNodeRequestErrors`,
`BasicDistributedZk2Test.addAndQueryDocs`); changed both to take
`JettySolrRunner` since their only callers already held one. Also removed
`BasicDistributedZkTest.createSolrCore`, a private method with zero callers
anywhere in the repo, found during the sweep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
