dsmiley commented on code in PR #4778:
URL: https://github.com/apache/solr/pull/4778#discussion_r3853558215
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/ConcurrentDeleteAndCreateCollectionTest.java:
##########
@@ -68,7 +69,7 @@ public void testConcurrentCreateAndDeleteDoesNotFail() throws
IOException {
final String collectionName = "collection" + i;
solrCluster.uploadConfigSet(configset("configset-2"), collectionName);
final String baseUrl =
solrCluster.getJettySolrRunners().get(0).getBaseUrl().toString();
- final SolrClient solrClient = getHttpSolrClient(baseUrl);
+ final SolrClient solrClient = new
HttpJettySolrClient.Builder(baseUrl).build();
Review Comment:
can get a new client via
solrCluster.getJettySolrRunners().get(0).newSolrClient(). Please apply this
pattern wherever possible on tests in this PR -- where the test code
deliberately needs a new client for some reason, and a JettySolrRunner is
in-scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
