serhiy-bzhezytskyy commented on PR #4778: URL: https://github.com/apache/solr/pull/4778#issuecomment-5384968219
Reworked to reuse getSolrClient()/newSolrClient() where a runner reference was available. Also removed newClient(int, int) -- its 4 callers all used timeouts shorter than the shared client's own default, so nothing needed them. Also tried migrating one AbstractFullDistribZkTestBase test (TestCustomStream) to SolrCloudTestCase as an experiment -- worked first try for this trivial case, but required tracing 2 layers of legacy inheritance to find the implicit setup defaults. Worth a separate, incremental effort, not a blanket migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
