dsmiley commented on PR #4778: URL: https://github.com/apache/solr/pull/4778#issuecomment-5383650170
I should have expressed more when I deprecated that method recently; sorry. I deprecated it because I'd guess that most callers should call getSolrClient() and then don't close it either, as it's lifecycle is managed by the runner. That loses a try-finally on the caller (nice), and avoids needless work and additional connections (nice). The clients are immutable (or should be). So why create a new vanilla client when the JettySolrRunner already has one? Additionally there's a new method: `newSolrClient(Collection)` that callers might use if they want a vanilla client scoped to one core/collection, inherited via the SolrBackend, which is new. So it was too much to also have the original `newClient` method, so I deprecated it. I forgot to deprecate `newClient` that takes the timeouts because there aren't many callers; I'd rather not keep the method. Too many similar ones on this class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
