dsmiley commented on code in PR #5354:
URL: https://github.com/apache/solr/pull/5354#discussion_r4593988632


##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by

Review Comment:
   ```suggestion
   # solr/core is most of the whole test suite, so it is split into four slices 
by
   ```



##########
.github/workflows/tests-modules-cloud.yml:
##########
@@ -0,0 +1,51 @@
+name: Cloud Modules Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-modules-cloud.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/cross-dc-manager/**'
+      - 'solr/modules/cross-dc/**'
+      - 'solr/modules/gcs-repository/**'
+      - 'solr/modules/jwt-auth/**'

Review Comment:
   jwt-auth isn't cloud



##########
gradle/testing/defaults-tests.gradle:
##########


Review Comment:
   nice



##########
.github/workflows/tests-modules-search.yml:
##########
@@ -0,0 +1,54 @@
+name: Search Modules Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:

Review Comment:
   perhaps add the test-framework too, as everything we do sits on it!



##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them
+      - 'solr/test-framework/**'
+      - 'solr/api/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run Solr Core Tests (${{ matrix.slice }})
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+
+    strategy:
+      fail-fast: false
+      matrix:
+        slice: [cloud, search, handler, other]
+        jvms: [2]
+        include:
+          # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe 
the 4 vCPUs
+          - slice: cloud
+            jvms: 3

Review Comment:
   Any harm in just using 3 for them all, and then inline away this jvm param?  
It'd simplify things.



##########
.github/workflows/tests-solrj.yml:
##########
@@ -0,0 +1,46 @@
+name: SolrJ Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-solrj.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/api/**'
+      - 'solr/solrj/**'
+      - 'solr/solrj-jetty/**'
+      - 'solr/solrj-zookeeper/**'

Review Comment:
   gonna be opinionated here and say that solrj-zookeeper is a lot more a 
SolrCloud inside Solr thing than it is a SolrJ thing.  If someone touches this 
code, it's *very* unlikely it has anything to do with SolrJ.  On the other 
hand, we had better have our solr-core tests running when solrj-zookeeper is 
touched!
   
   The direction we're heading in is to fold solrj-zookeeper back into 
solr-core.  Not there yet, but we're getting there.  Even if we never get 
there, what I said above holds.



##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them
+      - 'solr/test-framework/**'
+      - 'solr/api/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run Solr Core Tests (${{ matrix.slice }})
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+
+    strategy:
+      fail-fast: false
+      matrix:
+        slice: [cloud, search, handler, other]
+        jvms: [2]
+        include:
+          # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe 
the 4 vCPUs
+          - slice: cloud
+            jvms: 3
+
+    env:
+      # Top-level packages under org.apache.solr for each named slice.
+      # The "other" slice runs everything not listed here.
+      SLICE_CLOUD: cloud
+      SLICE_SEARCH: search uninverting spelling highlight analysis legacy 
index parser
+      SLICE_HANDLER: handler cli response request servlet jersey rest security 
api
+

Review Comment:
   Thinking aloud:  If I could re-organize our core module code, it'd be 
around: cli (soon to be separated!), cloud, server, node, core.  And maybe 
others, but those are the big pillars in my mind.  Ah well. I'm tempted to 
propose a big bang break-up for Solr 11... at least for the code to be in the 
right paths with the right packages... even if the surrounding modules aren't 
ready to be formed yet.



##########
.github/workflows/tests-solrj.yml:
##########
@@ -0,0 +1,46 @@
+name: SolrJ Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-solrj.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/api/**'
+      - 'solr/solrj/**'
+      - 'solr/solrj-jetty/**'
+      - 'solr/solrj-zookeeper/**'
+      - 'solr/solrj-streaming/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run SolrJ Tests
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+
+    - uses: ./.github/actions/prepare-for-build
+
+    - name: Test the SolrJ modules and the API module
+      run: ./gradlew :solr:api:test :solr:solrj:test :solr:solrj-jetty:test 
:solr:solrj-zookeeper:test :solr:solrj-streaming:test

Review Comment:
   let's use more test JVMs; like 3, up from the default of 2.



##########
.github/workflows/tests-modules-cloud.yml:
##########
@@ -0,0 +1,51 @@
+name: Cloud Modules Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-modules-cloud.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/cross-dc-manager/**'
+      - 'solr/modules/cross-dc/**'
+      - 'solr/modules/gcs-repository/**'
+      - 'solr/modules/jwt-auth/**'
+      - 'solr/modules/opentelemetry/**'

Review Comment:
   OTEL isn't cloud



##########
.github/workflows/tests-extraction.yml:
##########
@@ -0,0 +1,40 @@
+# The extraction module tests need Docker for the TikaServer tests of SolrCell,
+# so they get a workflow of their own.
+name: Extraction Module Tests
+

Review Comment:
   ```suggestion
   name: Extraction Module Tests
   
   # The extraction module tests need Docker for the TikaServer tests of 
SolrCell,
   # so they get a workflow of their own.
   
   ```
   
   other ymls consistently put the name first, then comments



##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them

Review Comment:
   not only are core tests built on the test framework, core is built on Solrj! 
 IMO we must include all solrj here.



##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them
+      - 'solr/test-framework/**'
+      - 'solr/api/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run Solr Core Tests (${{ matrix.slice }})
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+
+    strategy:
+      fail-fast: false
+      matrix:
+        slice: [cloud, search, handler, other]
+        jvms: [2]
+        include:
+          # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe 
the 4 vCPUs
+          - slice: cloud
+            jvms: 3
+
+    env:
+      # Top-level packages under org.apache.solr for each named slice.
+      # The "other" slice runs everything not listed here.
+      SLICE_CLOUD: cloud
+      SLICE_SEARCH: search uninverting spelling highlight analysis legacy 
index parser
+      SLICE_HANDLER: handler cli response request servlet jersey rest security 
api

Review Comment:
   these is cross-affinity here. It may be unavoidable.
   What if we rename SLICE_SEARCH to SLICE_CORE and SLICE_HANDLER to 
SLICE_NODE?  I'm thinking aspirational here.  I shouldn't over-bikeshed this... 
we can iterate later.
   
   I'd remove "cli" as it will soon be in another module anyway -- let it run 
in "other" for now.
   
   



##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them
+      - 'solr/test-framework/**'
+      - 'solr/api/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run Solr Core Tests (${{ matrix.slice }})
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+
+    strategy:
+      fail-fast: false
+      matrix:
+        slice: [cloud, search, handler, other]
+        jvms: [2]
+        include:
+          # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe 
the 4 vCPUs
+          - slice: cloud
+            jvms: 3
+
+    env:
+      # Top-level packages under org.apache.solr for each named slice.
+      # The "other" slice runs everything not listed here.
+      SLICE_CLOUD: cloud
+      SLICE_SEARCH: search uninverting spelling highlight analysis legacy 
index parser
+      SLICE_HANDLER: handler cli response request servlet jersey rest security 
api
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+
+    - uses: ./.github/actions/prepare-for-build
+
+    - name: Test solr/core slice "${{ matrix.slice }}"
+      run: |
+        args=()
+        case "${{ matrix.slice }}" in
+          cloud)   pkgs="$SLICE_CLOUD" ;;

Review Comment:
   if cloud, let's right here run solrj-zookeeper tests as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to