janhoy commented on code in PR #5354:
URL: https://github.com/apache/solr/pull/5354#discussion_r4596805068


##########
.github/workflows/tests-modules-search.yml:
##########
@@ -0,0 +1,54 @@
+name: Search Modules Tests
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:

Review Comment:
   Yes perhaps. Not sure if all these tests need to replicate the dependency 
structure between modules though. E.g. most `modules/` depend on `core`, but I 
don't want them all to run for every tiny javadoc edit in `core`. We must not 
forget that we also have Continous Testing in Jenkins that will catch those 
corner case interactions where something in one (gradle) module unexpetedly 
breaks something in another. I think the right call for most PR testing is 
focused module tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to