dsmiley commented on code in PR #5354:
URL: https://github.com/apache/solr/pull/5354#discussion_r4601220043
##########
.github/workflows/tests-modules-ops.yml:
##########
Review Comment:
I like the new name -- ops
##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,91 @@
+name: Solr Core Tests
+
+# solr/core is most of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. The slices are balanced from measured CI
+# timings: the cloud package alone is the largest unit in solr/core and sets
+# the critical path, so its api and overseer sub-packages run in the search
+# slice instead. The "other" slice is exclusion-based so that a new package
+# can never silently fall outside every slice.
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-core.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/core/**'
+ - 'solr/solrj-zookeeper/**'
+ # core tests are built on these; a change here can break them
+ - 'solr/test-framework/**'
+ - 'solr/api/**'
+ - 'solr/solrj/**'
+ - 'solr/solrj-jetty/**'
+ - 'solr/solrj-streaming/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Run Solr Core Tests (${{ matrix.slice }})
+
+ runs-on: ubuntu-latest
+ timeout-minutes: 25
+
+ strategy:
+ fail-fast: false
+ matrix:
+ slice: [cloud, search, handler, other]
+
+ env:
+ # Top-level packages under org.apache.solr for each named slice.
+ # The "other" slice runs everything not listed here.
+ SLICE_CLOUD: cloud
Review Comment:
Now that we're going to balance by time, the slice names have lost their
meaning. Let's use what use suggested of SLICE1, SLICE2, ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]