janhoy commented on code in PR #5354:
URL: https://github.com/apache/solr/pull/5354#discussion_r4598426094
##########
.github/workflows/tests-solrj.yml:
##########
@@ -0,0 +1,46 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-solrj.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/api/**'
+ - 'solr/solrj/**'
+ - 'solr/solrj-jetty/**'
+ - 'solr/solrj-zookeeper/**'
Review Comment:
🤖 Agreed, moved: core now triggers on `solrj-zookeeper/**` and runs its
tests, and the SolrJ workflow no longer does.
##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based
so
+# that a new package can never silently fall outside every slice.
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-core.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/core/**'
+ # core tests are built on these; a change here can break them
+ - 'solr/test-framework/**'
+ - 'solr/api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Run Solr Core Tests (${{ matrix.slice }})
+
+ runs-on: ubuntu-latest
+ timeout-minutes: 25
+
+ strategy:
+ fail-fast: false
+ matrix:
+ slice: [cloud, search, handler, other]
+ jvms: [2]
+ include:
+ # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe
the 4 vCPUs
+ - slice: cloud
+ jvms: 3
+
+ env:
+ # Top-level packages under org.apache.solr for each named slice.
+ # The "other" slice runs everything not listed here.
+ SLICE_CLOUD: cloud
+ SLICE_SEARCH: search uninverting spelling highlight analysis legacy
index parser
+ SLICE_HANDLER: handler cli response request servlet jersey rest security
api
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+
+ - uses: ./.github/actions/prepare-for-build
+
+ - name: Test solr/core slice "${{ matrix.slice }}"
+ run: |
+ args=()
+ case "${{ matrix.slice }}" in
+ cloud) pkgs="$SLICE_CLOUD" ;;
Review Comment:
🤖 Done, but in the `other` slice rather than cloud: cloud is the critical
path at 16.6 min, `other` at 12.0 has the headroom.
##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based
so
+# that a new package can never silently fall outside every slice.
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-core.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/core/**'
+ # core tests are built on these; a change here can break them
Review Comment:
🤖 Added solrj, solrj-jetty and solrj-streaming to the triggers. Compile
breaks were already caught by Precommit, so this buys behavioural coverage at
the cost of four core jobs on every SolrJ PR.
##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based
so
+# that a new package can never silently fall outside every slice.
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-core.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/core/**'
+ # core tests are built on these; a change here can break them
+ - 'solr/test-framework/**'
+ - 'solr/api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Run Solr Core Tests (${{ matrix.slice }})
+
+ runs-on: ubuntu-latest
+ timeout-minutes: 25
+
+ strategy:
+ fail-fast: false
+ matrix:
+ slice: [cloud, search, handler, other]
+ jvms: [2]
+ include:
+ # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe
the 4 vCPUs
+ - slice: cloud
+ jvms: 3
+
+ env:
+ # Top-level packages under org.apache.solr for each named slice.
+ # The "other" slice runs everything not listed here.
+ SLICE_CLOUD: cloud
+ SLICE_SEARCH: search uninverting spelling highlight analysis legacy
index parser
+ SLICE_HANDLER: handler cli response request servlet jersey rest security
api
Review Comment:
🤖 cli moved to `other`. Holding off on the renames: the slices are cut for
balance now, not concepts, and the search slice also carries `cloud.api` and
`cloud.overseer`. Worth re-cutting when the module split lands.
##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based
so
+# that a new package can never silently fall outside every slice.
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-core.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/core/**'
+ # core tests are built on these; a change here can break them
+ - 'solr/test-framework/**'
+ - 'solr/api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Run Solr Core Tests (${{ matrix.slice }})
+
+ runs-on: ubuntu-latest
+ timeout-minutes: 25
+
+ strategy:
+ fail-fast: false
+ matrix:
+ slice: [cloud, search, handler, other]
+ jvms: [2]
+ include:
+ # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe
the 4 vCPUs
+ - slice: cloud
+ jvms: 3
Review Comment:
🤖 Inlined now: every slice runs `-Ptests.jvms=2`.
##########
.github/workflows/tests-modules-ops.yml:
##########
@@ -0,0 +1,51 @@
+name: Cloud Modules Tests
+
+on:
+ pull_request:
+ branches:
+ - '*'
+ paths:
+ - '.github/workflows/tests-modules-cloud.yml'
+ - 'gradle/libs.versions.toml'
+ - 'solr/cross-dc-manager/**'
+ - 'solr/modules/cross-dc/**'
+ - 'solr/modules/gcs-repository/**'
+ - 'solr/modules/jwt-auth/**'
+ - 'solr/modules/opentelemetry/**'
Review Comment:
🤖 Renamed to `Ops Modules Tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]