janhoy commented on code in PR #5354:
URL: https://github.com/apache/solr/pull/5354#discussion_r4596714365


##########
.github/workflows/tests-core.yml:
##########
@@ -0,0 +1,81 @@
+name: Solr Core Tests
+
+# solr/core is 78% of the whole test suite, so it is split into four slices by
+# Java package that run in parallel. Each slice is sized to finish in roughly
+# 15 minutes on an ubuntu-latest runner. The "other" slice is exclusion-based 
so
+# that a new package can never silently fall outside every slice.
+
+on:
+  pull_request:
+    branches:
+      - '*'
+    paths:
+      - '.github/workflows/tests-core.yml'
+      - 'gradle/libs.versions.toml'
+      - 'solr/core/**'
+      # core tests are built on these; a change here can break them
+      - 'solr/test-framework/**'
+      - 'solr/api/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Run Solr Core Tests (${{ matrix.slice }})
+
+    runs-on: ubuntu-latest
+    timeout-minutes: 25
+
+    strategy:
+      fail-fast: false
+      matrix:
+        slice: [cloud, search, handler, other]
+        jvms: [2]
+        include:
+          # cloud tests mostly wait on ZooKeeper and Jetty, so oversubscribe 
the 4 vCPUs
+          - slice: cloud
+            jvms: 3

Review Comment:
   First run had abug and ran cloud tests with one runner having 2 jvms and the 
other one 3. The 2-jvm ran faster, so in current version we stick to 2 across 
the board.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to