[ 
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008873#comment-14008873
 ] 

ASF GitHub Bot commented on TAJO-774:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/13#discussion_r13048589
  
    --- Diff: 
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
    @@ -349,43 +408,63 @@ public boolean equals(Object object) {
             return false;
           }
         }
    +
    +    @Override
    +    public Object clone() throws CloneNotSupportedException {
    +      ListPartition listPartition = (ListPartition) super.clone();
    +      listPartition.columns = new ColumnReferenceExpr[columns.length];
    +      for (int i = 0; i < columns.length; i++) {
    +        listPartition.columns[i] = (ColumnReferenceExpr) 
columns[i].clone();
    +      }
    +      if (specifiers != null) {
    +        listPartition.specifiers = new ArrayList<ListPartitionSpecifier>();
    +        for (ListPartitionSpecifier specifier : specifiers) {
    +          listPartition.specifiers.add(specifier);
    +        }
    +      }
    +      return listPartition;
    +    }
       }
     
    -  public static class ColumnPartition extends PartitionMethodDescExpr {
    +  public static class ColumnPartition extends PartitionMethodDescExpr 
implements Cloneable {
         @Expose @SerializedName("Columns")
         private ColumnDefinition [] columns;
         @Expose @SerializedName("IsOmitValues")
         private boolean isOmitValues;
    --- End diff --
    
    It seems unnecessary.


> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
>                 Key: TAJO-774
>                 URL: https://issues.apache.org/jira/browse/TAJO-774
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical 
> planning part for window function support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to