[jira] [Commented] (TAJO-774) Implement logical plan part and physical executor for window function.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008888#comment-14008888
 ] 

ASF GitHub Bot commented on TAJO-774:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/13#discussion_r13049124
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java ---
    @@ -751,6 +756,58 @@ public void registerExprWithNode(Expr expr, 
LogicalNode node) {
           return (T) exprToNodeMap.get(ObjectUtils.identityToString(expr));
         }
     
    +    public void setHasWindowFunction() {
    +      hasWindowFunction = true;
    +    }
    +
    +    public boolean hasWindowSpecs() {
    +      return hasWindowFunction;
    +    }
    +//
    +//    public String addWindowSpecs(WindowSpecExpr windowSpecExpr) {
    --- End diff --
    
    Please remove commented out codes.


> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
>                 Key: TAJO-774
>                 URL: https://issues.apache.org/jira/browse/TAJO-774
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical 
> planning part for window function support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)