[ 
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009796#comment-14009796
 ] 

ASF GitHub Bot commented on TAJO-774:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/13#discussion_r13083687
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/eval/WindowFunctionEval.java ---
    @@ -0,0 +1,100 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.engine.eval;
    +
    +import com.google.gson.annotations.Expose;
    +import org.apache.tajo.algebra.WindowSpecExpr;
    +import org.apache.tajo.catalog.FunctionDesc;
    +import org.apache.tajo.catalog.Schema;
    +import org.apache.tajo.catalog.SortSpec;
    +import org.apache.tajo.common.TajoDataTypes.DataType;
    +import org.apache.tajo.datum.Datum;
    +import org.apache.tajo.engine.function.AggFunction;
    +import org.apache.tajo.engine.function.FunctionContext;
    +import org.apache.tajo.engine.planner.logical.WindowSpec;
    +import org.apache.tajo.storage.Tuple;
    +import org.apache.tajo.storage.VTuple;
    +
    +public class WindowFunctionEval extends AggregationFunctionCallEval 
implements Cloneable {
    +  @Expose private SortSpec [] sortSpecs;
    +  @Expose WindowSpec.WindowFrame windowFrame;
    +  private Tuple params;
    --- End diff --
    
    'Expose' is missed.


> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
>                 Key: TAJO-774
>                 URL: https://issues.apache.org/jira/browse/TAJO-774
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical 
> planning part for window function support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to