[ 
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008877#comment-14008877
 ] 

ASF GitHub Bot commented on TAJO-774:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/13#discussion_r13048763
  
    --- Diff: 
tajo-algebra/src/main/java/org/apache/tajo/algebra/WindowFunctionExpr.java ---
    @@ -19,19 +19,17 @@
     package org.apache.tajo.algebra;
     
     import com.google.common.base.Objects;
    +import com.google.gson.annotations.Expose;
     import org.apache.tajo.util.TUtil;
     
    -public class WindowFunctionExpr extends Expr {
    -  // set function
    -  GeneralSetFunctionExpr function;
    +public class WindowFunctionExpr extends GeneralSetFunctionExpr {
     
       // over clause - only one of both is used.
    -  private String windowName;
    -  private WindowSpecExpr windowSpec;
    +  @Expose private String windowName;
    --- End diff --
    
    Would you add a serialized name for the consistency of json representation?


> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
>                 Key: TAJO-774
>                 URL: https://issues.apache.org/jira/browse/TAJO-774
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical 
> planning part for window function support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to