[
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008879#comment-14008879
]
ASF GitHub Bot commented on TAJO-774:
-------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/13#discussion_r13048813
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/WindowSpecExpr.java ---
@@ -19,17 +19,14 @@
package org.apache.tajo.algebra;
import com.google.common.base.Objects;
+import com.google.gson.annotations.Expose;
import org.apache.tajo.util.TUtil;
-public class WindowSpecExpr extends Expr {
- private String windowName;
- private Expr [] partitionKeys; // OVER (PARTITION BY ?,...,?)
- private Sort.SortSpec [] sortSpecs; // OVER (... ORDER BY ?,...,?)
- private WindowFrame windowFrame;
-
- public WindowSpecExpr() {
- super(OpType.WindowSpec);
- }
+public class WindowSpecExpr implements Cloneable {
--- End diff --
The name can make users confused. Would you change the name not including
'Expr'?
> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
> Key: TAJO-774
> URL: https://issues.apache.org/jira/browse/TAJO-774
> Project: Tajo
> Issue Type: Sub-task
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical
> planning part for window function support.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
