[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055301#comment-15055301
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457157
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
---
@@ -423,7 +425,9 @@ public synchronized Schema addColumn(String name,
TypeDesc typeDesc) {
Column newCol = new Column(normalized, typeDesc);
fields.add(newCol);
fieldsByQualifiedName.put(newCol.getQualifiedName(), fields.size() -
1);
- fieldsByName.put(newCol.getSimpleName(), TUtil.newList(fields.size() -
1));
+ List inputList = new ArrayList<>();
--- End diff --
Please specify type.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
