[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055303#comment-15055303
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457276
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/function/FunctionSignature.java
---
@@ -109,7 +113,9 @@ public FunctionSignatureProto getProto() {
FunctionSignatureProto.Builder builder =
FunctionSignatureProto.newBuilder();
builder.setType(functionType);
builder.setName(name);
- builder.addAllParameterTypes(TUtil.newList(paramTypes));
+ List inputList = new ArrayList<>();
+ inputList.addAll(Arrays.asList(paramTypes));
+ builder.addAllParameterTypes(inputList);
--- End diff --
inputList is redundant. It can be replaced with just
```Arrays.asList(paramTypes)```.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
