[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055305#comment-15055305
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457328
--- Diff: tajo-common/src/main/java/org/apache/tajo/util/TUtil.java ---
@@ -185,7 +155,9 @@ public static boolean checkEquals(int [] s1, int [] s2)
{
if (map.containsKey(k1)) {
map.get(k1).addAll(list);
} else {
- map.put(k1, TUtil.newList(list));
+ List inputList = new ArrayList<>();
+ inputList.addAll(list);
--- End diff --
These lines can be rewritten with a single constructor call.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
