[ 
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055311#comment-15055311
 ] 

ASF GitHub Bot commented on TAJO-1999:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/891#discussion_r47457452
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java 
---
    @@ -1312,7 +1312,9 @@ public void testInsertIntoUsingPut() throws Exception 
{
         } finally {
           executeString("DROP TABLE hbase_mapped_table PURGE").close();
     
    -      
client.unsetSessionVariables(TUtil.newList(HBaseStorageConstants.INSERT_PUT_MODE));
    +      List inputList = new ArrayList<>();
    +      
inputList.addAll(Arrays.asList(HBaseStorageConstants.INSERT_PUT_MODE));
    +      client.unsetSessionVariables(inputList);
    --- End diff --
    
    Can be rewritten with a simple Arrays.asList() call.


> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-1999
>                 URL: https://issues.apache.org/jira/browse/TAJO-1999
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility 
> methods anymore. We need to eliminate them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to