[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055315#comment-15055315
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457496
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/BroadcastJoinRule.java
---
@@ -387,7 +389,8 @@ private long estimateOutputVolumeInternal(LogicalNode
node) throws TajoInternalE
* @param block
*/
private void checkTotalSizeOfBroadcastableRelations(Context context,
ExecutionBlock block) {
- List<ScanNode> broadcastCandidates =
TUtil.newList(block.getBroadcastRelations());
+ List<ScanNode> broadcastCandidates = new ArrayList<>();
+ broadcastCandidates.addAll(block.getBroadcastRelations());
--- End diff --
Can be rewritten with a single constructor call.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
