[
https://issues.apache.org/jira/browse/TEZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214357#comment-14214357
]
Jeff Zhang commented on TEZ-1773:
---------------------------------
Comments:
* Is the trySetErrorCause necessary in
TaskAttemptImpl.OutputReportedFailedTransition ? The following 2 transition
(either TerminatedAfterSuccessHelper or TerminatedWhileRunningTransition)
should will call trySetErrorCause
* TERMINATED_BY_CLIENT is not used. I think it should be passed from
DAGKilledTransition to TaskAttempt
* Is this should be CONTAINER_LAUNCH_FAILED in
AMContainerImpl.LaunchFailedTransition?
{code}
protected static class LaunchFailedTransition implements
SingleArcTransition<AMContainerImpl, AMContainerEvent> {
@Override
public void transition(AMContainerImpl container, AMContainerEvent cEvent) {
if (container.pendingAttempt != null) {
AMContainerEventLaunchFailed event = (AMContainerEventLaunchFailed)
cEvent;
// for a properly setup cluster this should almost always be an app
error
container.sendTerminatingToTaskAttempt(container.pendingAttempt,
event.getMessage(), TaskAttemptErrorCause.APPLICATION_ERROR);
}
container.unregisterFromTAListener();
container.deAllocate();
}
}
{code}
> Add attempt failure cause enum to the attempt failed/killed history record
> --------------------------------------------------------------------------
>
> Key: TEZ-1773
> URL: https://issues.apache.org/jira/browse/TEZ-1773
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-1773.1.patch
>
>
> Having an enum in it, will provide a programmatic means to present, analyse
> and debug unsuccessful attempts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
