[ 
https://issues.apache.org/jira/browse/TEZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222619#comment-14222619
 ] 

Jeff Zhang commented on TEZ-1773:
---------------------------------

bq. Not sure what you mean here. This is designed to be similar to diagnostic 
event. Had to use interface because it already extends TaskAttemptEvent. Did 
not make it part of TaskAttemptEvent since there are other events that dont 
need to have a termination cause. If needed we can change that later.
Please ignore it, I mistake some of the TaskAttemptTerminationEvent has 1-1 
relationship with some of the TaskAttemptTerminationCause. 

New patch lgtm except one thing: Why put TaskAttemptTerminationCause in 
tez-common rather than tez-dag ? Only tez-dag and test of 
tez-yarn-timeline-history use it. 

> Add attempt failure cause enum to the attempt failed/killed history record
> --------------------------------------------------------------------------
>
>                 Key: TEZ-1773
>                 URL: https://issues.apache.org/jira/browse/TEZ-1773
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: TEZ-1773.1.patch, TEZ-1773.2.patch, TEZ-1773.3.patch, 
> TEZ-1773.4.patch
>
>
> Having an enum in it, will provide a programmatic means to present, analyse 
> and debug unsuccessful attempts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to