[
https://issues.apache.org/jira/browse/TEZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220711#comment-14220711
]
Jeff Zhang commented on TEZ-1773:
---------------------------------
Comments:
* Would it be better change TaskAttemptImpl.trySetErrorCause to
trySetTerminationCause to make it consistent with DAG/Vertex ?
* Would it be better to remove errorCause from constructor, and set it
directly, since the terminationCause bind with the TerminationEvent closely ?
Here's one example
{code}
public TaskAttemptEventContainerTerminatedBySystem(TezTaskAttemptID id,
String diagnostics,
TaskAttemptTerminationCause errorCause) {
super(id, TaskAttemptEventType.TA_CONTAINER_TERMINATED_BY_SYSTEM);
this.diagnostics = diagnostics;
this.errorCause = errorCause;
}
{code}
* There's no terminationCause setting for Task, although we have
TaskTerminationCause ? Is this necessary ? (If yes, we can do it in another
jira )
> Add attempt failure cause enum to the attempt failed/killed history record
> --------------------------------------------------------------------------
>
> Key: TEZ-1773
> URL: https://issues.apache.org/jira/browse/TEZ-1773
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-1773.1.patch, TEZ-1773.2.patch, TEZ-1773.3.patch
>
>
> Having an enum in it, will provide a programmatic means to present, analyse
> and debug unsuccessful attempts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
