xianjingfeng commented on code in PR #1318:
URL:
https://github.com/apache/incubator-uniffle/pull/1318#discussion_r1404082952
##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -211,6 +230,27 @@ boolean checkIsSpaceEnough() {
return isHealthy;
}
+ boolean checkWatermarkLimit() {
+ double usagePercent = getWholeDiskUsedSpace(storageDir) * 100.0 /
getTotalSpace(storageDir);
Review Comment:
`getTotalSpace` has been invoked in `getWholeDiskUsedSpace`, so could we
avoid invoking it twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
