awdavidson commented on PR #1318: URL: https://github.com/apache/incubator-uniffle/pull/1318#issuecomment-1829215564
Apologies a little late to this. I agree with keeping ‘rss.server.disk.capacity’ for now. This setting is useful for making uniffle aware of the disk allocated when deploying uniffle on Kubernetes using a volume with a size limit (mainly for colocation as mentioned). As for the watermark check, I would say yes, when a disk capacity is configured we should check against the disk size and uniffle disk used capacity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
