xianjingfeng commented on PR #1318: URL: https://github.com/apache/incubator-uniffle/pull/1318#issuecomment-1825366841
> > Should we remove `rss.server.disk.capacity`? > > When using the whole disk, capacity is not specified explictly. > > But when colocation or we hope uniffle uses the limited disk, the capacity is also needed. Right? > > If so, the watermark limit check should be based on two ways, including wholeUsedDisk/wholeDiskSize and uniffleUsedDisk/uniffleDiskCapacity ? Right @xianjingfeng Right -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
