zuston commented on PR #1318:
URL:
https://github.com/apache/incubator-uniffle/pull/1318#issuecomment-1829135615
> > > > But I have no idea how to take the compatible way to implement?
> > >
> > >
> > > uniffleUsedDisk=du ${uniffle_data_dir} ? And add an option for
choosing which way to check the disk?
> >
> >
> > I think the unified way will be better. Like this?
> > For high watermark check logic:
> > `if (uniffleUsedDiskSize > uniffleSpecifiedCapacity * highWatermarkRatio
|| WholeDiskUsed > wholeDiskSize * highWatermarkRatio)`
> > For the low watermark check logic:
> > `if (uniffleUsedDiskSize < uniffleSpecifiedCapacity * lowWatermarkRatio
&& WholeDiskUsed < wholeDiskSize * lowWatermarkRatio)`
> > WDYT? @xianjingfeng CC @jerqi
>
> Do we have an interface DiskManagePolicy? Users can use different policies
by different configuration options.
This is another way. But I think this is enough for above solutions to solve
this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
