> OK, we have a conflicting API regarding lcd_write_pixel. Depending on GLCD, > last parameter is either a color or a mode (on|off|xor)
What is xor? clear? A "clear" color should not be implemented by glcd_common, it should be implemented by glcd_write_pixel() which is in the glcd device library. If the color "clear", then don't write a pixel. > Colors should be handled outside procedure parameters, defining pen & bg > color *before* calling plotting procedures. I think this is what we agreed, > right ? If so glcd_common should be updated accordingly. I agree, I just never got around to changing this. > On the other side, since "mode" is part of lcd_write_pixel signature, all > plotting procs (line, box, ellipse, ...) should take a "mode" parameter to > specify whether we want to make pixels on, off or xor. I'm not in favor of > putting this parameter outside lcd_write_pixel signature as pen color for > instance, because "mode" is very tied to one pixel, whereas pen color looks > like more a global LCD option. ON and OFF are colors for you so why have this mode perimeter when you can just choose your pen and background colors accordingly? It also does not seem useful on color GLCDs. I think what you are really asking for is inverted colors. Inverted colors could be taken care of by the glcd device lib. So, I suppose if you want this implemented your glcd device library could have a variable or constant to set inverted / non-inverted. > I tried to use glcd_common's lcd_line(), but no success though... Did you get anything on your screen? Maybe output the currentx,currenty values to the serial port where you see lcd_write_pixel in the line proc. We can probably plot it by hand or use excel. Maybe you can send me this data? Did you find a good way to turn on and off the cache? (this is what the old glcd cache code was for). Should this cache be available for other GLCDs? Thanks for continuing your hard work on this! Matt. -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
