On 10/28/2010 05:06 PM, Craig Kelley wrote:
That's fairly damning... At a minimum, whoever wrote the Harmony version copied the field definition block verbatim.
OTOH, the comment says that 4/5 fields are defined by an RFC, so it's quite obvious that people would declare them in the same order... But the smell persists for the other stuff.
53 private static final String ANY_POLICY = "2.5.29.32.0";54 55 // every node has one parent, and zero or more children56 private PolicyNodeImpl mParent; 57 private HashSet<PolicyNodeImpl> mChildren;58 59 // the 4 fields specified by RFC 328060 private String mValidPolicy; 61 private HashSet<PolicyQualifierInfo> mQualifierSet; 62 private boolean mCriticalityIndicator; 63 private HashSet<String> mExpectedPolicySet; 64 private boolean mOriginalExpectedPolicySet;65 66 // the tree depth67 private int mDepth; 68 // immutability flag 69 private boolean isImmutable = false;
-- You received this message because you are subscribed to the Google Groups "The Java Posse" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/javaposse?hl=en.
