> You probably don't need P4 specific credential type. You should be able to get away with a Domain requirements/specification and the standard username/password credentials type You are right, but such migration requires 1.509.x to be a minimal supported version. The proposed PR has been created in away, which allows to retain the current minimal version (with an external implementation of Credentials)
If we start the development of "Perforce 2.0", all existing approaches should be re-considered together with other community members. 2014-04-18 15:28 GMT+04:00 Stephen Connolly <[email protected] >: > I'm just putting those two things "out there" as it is better to integrate > credentials from the beginning... and a smart SCM-API implementation can be > leveraged to deliver better polling support for regular job types... which > again calls for early integration. > > You probably don't need P4 specific credential type. You should be able to > get away with a Domain requirements/specification and the standard > username/password credentials type > > > On 18 April 2014 11:55, Oleg Nenashev <[email protected]> wrote: > >> @Stephen >> Yes, of course. In the case of the legacy plugin refactoring there will >> be a P4CredentialsProvider extension point, which will have the >> implementation for "Credentials Plugin" ( >> https://github.com/jenkinsci/perforce-plugin/pull/45). AFAIK, Paul has >> implemented the integration in his plugin PoC. SCM-API would be useful as >> well. >> >> The real issue is an approach to be used... >> >> - Paul (from the Perforce SCM vendor) wants to create a new plugin >> and to sacrifice some features from the previous one. >> - Seems that other discussion participants (including me) prefer the >> refactoring approach with a smooth migration for users. >> - From my side, the Perforce plugin is relatively stable, so there is >> no urgent need to spend many man-weeks to integrate all required features >> to the new plugin and to migrate existing jobs. >> >> Nobody wants to waste his efforts, hence the maintenance/development of >> the original Perforce plugin just hangs. This plugin definitely requires a >> major refactoring (the Hudson compatibility has been maintained for a long >> time, so there is no support of tasty Jenkins features), so we definitely >> need to select a way to move forward. >> BR, Oleg Nenashev >> >> >> >> >> 2014-04-18 13:42 GMT+04:00 Stephen Connolly < >> [email protected]>: >> >> hope you are integrating with the credentials and the scm-api plugins >>> >>> >>> On 18 April 2014 10:33, Paul Allen <[email protected]> wrote: >>> >>>> Hi Rob, >>>> >>>> The refactoring effort would be so wide spread there would be very >>>> little, if anything, left. >>>> >>>> By removing the underlying p4 command wrapper (Tek42) and replacing it >>>> with the p4-java api would require a re-write of all the functions. In >>>> addition the behavioural changes to the use of Perforce workspaces and >>>> authentication would change most of the user interface. >>>> >>>> I suggest that we either create a new plugin 'p4' or fork/rename the >>>> existing plugin. A new plugin would be less disruptive to the existing >>>> user base and give the opportunity for a clean start. >>>> >>>> Paul >>>> >>>> On 17 Apr 2014, at 19:23, Rob Petti <[email protected]> wrote: >>>> >>>> > I thought it was decided that refactoring the old plugin was the >>>> better way to go? It's less of an impact on users, and preserves all of the >>>> required functionality. >>>> > >>>> > If not, then just make a new repo, I guess... >>>> > >>>> > On Thursday, 17 April 2014 10:52:20 UTC-6, pallen wrote: >>>> > I have been discussing the plugin for sometime over email. >>>> > >>>> > I'll CC Rob and the others... >>>> > >>>> > Paul >>>> > >>>> > On 17 Apr 2014, at 16:59, Jesse Glick <[email protected]> wrote: >>>> > >>>> > > On Thu, Apr 17, 2014 at 11:51 AM, Paul Allen <[email protected]> >>>> wrote: >>>> > >> Whilst the new plugin provides all the basic SCM functions, it is >>>> not yet as feature rich. We plan to add features [...] >>>> > >> >>>> > >> [...] perhaps there is a way to branch (fork) the old codebase >>>> into a legacy area? >>>> >>>> > > >>>> > > A bit more work, but arguably better for users, would be to include >>>> > > the new refactored implementation inside the existing plugin (in >>>> trunk >>>> > > versions). For a time, users of the plugin would see two SCM >>>> > > options--Perforce (v1) and Perforce (v2)--with somewhat different >>>> >>>> > > configuration UIs and functionality. They could experiment with >>>> > > switching to v2, or go back for a while, on a project-by-project >>>> > > basis. You could even decide that v1 configurations restricted to a >>>> > > certain set of commonly used features would be safe to automatically >>>> > > upgrade (i.e., readResolve) to a v2 configuration. Eventually the v1 >>>> > > implementation could be dropped, or rather exist only as a class >>>> with >>>> > > a readResolve method. >>>> > > >>>> > > This is of course assuming that the current maintainer(s) of >>>> > > perforce-plugin are aware of your effort and on board with it. >>>> > > >>>> > > -- >>>> > > You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> > > To unsubscribe from this group and stop receiving emails from it, >>>> send an email to [email protected]. >>>> > > For more options, visit https://groups.google.com/d/optout. >>>> > >>>> > >>>> > >>>> > >>>> -------------------------------------------------------------------------------- >>>> > This email and any files transmitted with it are confidential and >>>> intended >>>> > solely for the use of the individual or entity to whom they are >>>> addressed. If >>>> > you have received this email in error please notify the system >>>> manager. Please >>>> > note that any views or opinions presented in this email are solely >>>> those of the >>>> > author and do not necessarily represent those of Perforce Software. >>>> Finally, >>>> > the recipient should check this email and any attachments for the >>>> presence of >>>> > viruses. Perforce Software accepts no liability for any damage caused >>>> by any >>>> > virus transmitted by this email. >>>> > >>>> > Perforce Software UK Ltd is registered in England and Wales as >>>> company no. >>>> > 3816019 at the following address: West Forest Gate, Wellington Road, >>>> Wokingham, >>>> > RG40 2AT, UK >>>> > >>>> -------------------------------------------------------------------------------- >>>> > >>>> > -- >>>> > You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> > To unsubscribe from this group and stop receiving emails from it, >>>> send an email to [email protected]. >>>> > For more options, visit https://groups.google.com/d/optout. >>>> >>>> >>>> >>>> >>>> -------------------------------------------------------------------------------- >>>> This email and any files transmitted with it are confidential and >>>> intended >>>> solely for the use of the individual or entity to whom they are >>>> addressed. If >>>> you have received this email in error please notify the system manager. >>>> Please >>>> note that any views or opinions presented in this email are solely >>>> those of the >>>> author and do not necessarily represent those of Perforce Software. >>>> Finally, >>>> the recipient should check this email and any attachments for the >>>> presence of >>>> viruses. Perforce Software accepts no liability for any damage caused >>>> by any >>>> virus transmitted by this email. >>>> >>>> Perforce Software UK Ltd is registered in England and Wales as company >>>> no. >>>> 3816019 at the following address: West Forest Gate, Wellington Road, >>>> Wokingham, >>>> RG40 2AT, UK >>>> >>>> -------------------------------------------------------------------------------- >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
