I also hate "pinned". WtF does it mean? I now know, but it is sorta crazy. If we have to keep it, we have to keep it, but it does suck.
On Wed, Sep 16, 2015 at 9:09 AM, Tom Fennelly <[email protected]> wrote: > On Wednesday, September 16, 2015 at 2:50:31 PM UTC+1, Jesse Glick wrote: >> >> On Wed, Sep 16, 2015 at 3:42 AM, Tom Fennelly <[email protected]> >> wrote: >> > The plugin in WEB-INF/detached-plugins is already already installed in >> > "this" jenkins instance. >> > The only effect here will be a possible upgrade of the plugin if the >> > installed version is less than the bundled version AND the installed >> version >> > is not pinned. >> >> -1, `*.jpi.pinned` should be ignored henceforth, > > > Daniel Beck is of the opinion that .pinned should be honoured. > > It would help if you said why you think this. > > >> and we should leave >> the installed version alone, period. >> > > Again, it would be helpful to know why you say this. > > What I have seen here is that, if left with just the installed version > (from the previous release - pre upgrade), you can end up getting > exceptions on upgrade. > > For example, Jenkins 1.547 has external-monitor-job version 1.2. Version > 1.4 of this plugin received updates that were moved out from Jenkins core > <https://github.com/jenkinsci/external-monitor-job-plugin/commit/4175bb5f4fefe0fd7ffa73e195bd65233f83bdf5>. > Jenkins > core now has a hard dependency on external-monitor-job version 1.4+ > (probably indirectly via one of the plugins that were detached between > those releases?). Therefore, without updating this plugin to at least > version 1.4 as part of the upgrade, we get the error you saw 2 days ago (not > able to resolve <https://gist.github.com/tfennelly/c3211d3a8331db4b1c86> > hudson.model.Messages.ExternalJob_DisplayName > <https://gist.github.com/tfennelly/c3211d3a8331db4b1c86>) when upgrading > from 1.547 to a new Jenkins that doesn't run version 1.4 of this plugin. > > Maybe this could be solved by only updating already installed detached > plugins if the new version is a dependency of one of the detached plugins > since the last release? > > The only other way I can see of solving this is by telling people that > they need to update all plugins before shutting down the old version of > Jenkins and installing the new version. That sucks imo (and probably > wouldn't work anyway in many cases). Alternatively, we could just say that > they need to manually update plugins after upgrade, which also seems to > suck. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/kRobm-cxFw8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/61c9a184-ef21-447d-88db-8886bfa33ab5%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/61c9a184-ef21-447d-88db-8886bfa33ab5%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAOcHHXxQeBZb78rjJcZeo1aF3hBd1w8sCTrqxB74oD5hNjkDRw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
