On Sunday, December 18, 2016 at 9:11:12 PM UTC, Baptiste Mathus wrote: > > @James, so can you please give us an update of the current state about > this? > > My understanding is the following below, can you confirm/complete? > > 2016-12-07 13:01 GMT+01:00 James Nord <[email protected] <javascript:>>: > >> I am -1000 on this. >> >> The code does not pass tests on windows. Using java8 you force me to use >> a Virtual machine which sucks. >> > > So, IIUC, the tests are actually already failing with JDK7. >
On windows they fail with JDK7 or JDK8 - the issue is that you can not have a non virtual dev env on Windows 10 iff you move to require JDK8 as bash in ubuntu in windows does not support JDK8 > So though I agree this is important to fix (and Alex provided an > interested feedback about that, thanks Alex!), I guess this isn't a > criterion for JDK7=>JDK8 upgrade, right? > Well that depends... Currently I can build on windows using bash on ubuntu on windows using JDK7. And as such if you required JDK8 I would not be able to build (and have all the unit tests passing) > > >> >> Using Windows subsystem for Linux gets you ubuntu 14.04 which does not >> have native support for JDK8. >> > > If the first reason is actually fixable, does it make that second one > still actual? My understanding is no, because w/o Linux specific tests, you > would be able to work without falling back to using the VM subsystem. > I don't follow... > > And even if so, IIRC, we found there was apparently a (currently) Beta > program when one could get 16.04, hence JDK8, right? > Right..... Let me switch my primary OS over to use Windows insider program as well as Beta software I already have to use, what could possibly go wrong :-P > In that case, it should/could appear reasonable then because in the > meantime of the actual baseline upgrade (D+3 Months for weeklies as per > Oliver's proposal) that Beta could possibly have graduated to GA (if it > hasn't already?). > Well in 3 months I hope the tests could be fixed and stay fixed instead :-) (OT: I think the MS updates come in 6 month intervals so 3 months from now would be a little too quick) > > IOW, do you still have any reason to want to block that baseline upgrade, > or are you now fine with it? > What I'm saying is that by the time this call is made to switch there needs to be a native solution for building Jenkins on Windows (and Linux and OSX[1]). The easiest approach I see would be to fix the unit tests /code - which Alex already took a look at and should be possible. So I am +1k on switching to JDK8 with the proviso that at the time the call is made to do that the code is building and passing tests correctly. [1] not that there are any OSX agents on ci.jenkins.io - but normally OSx is closeish enough to Linux that you don't hit things like locking/network stack differences/line ends/spaces in dir names which cause tests/code to fail. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cf7f0681-ab03-499b-9b04-31ff8f591d75%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
