chia7712 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2408616573
> The ClientsMetricManager keeps the client instance cache at a limit of 16384. The active connections can be low, but connections can be created and destroyed in short span. Which hits the cache limit and results in cache miss for new connections. I assume the 'short span' is caused by an unexpected connection issue rather than a malicious client, as preventing malicious clients is a different issue. The root cause of hitting the cache limit is that ClientMetricsManager creates many meaningless clientInstanceIds for the 'short span' because their GetTelemetrySubscriptionsRequest doesn't include a valid UUID. Perhaps we could update the protocol to require that GetTelemetrySubscriptionsRequest must include a client instance ID? In KIP-1082, we agreed that clients are capable of generating UUIDs. With this approach, ClientMetricsManager would no longer create meaningless clientInstanceIds for short spans, as they would always use the same UUID (acting as a kind of incarnation). @apoorvmittal10 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
