apoorvmittal10 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2410292857
>I feel this situation is similar to the consumer membership issue. To some extent yes. >What do you think about using RPC-level cleanup by sending a DeleteTelemetrySubscriptions request? I think if we add a definite way of determining when client connection is terminated at broker then we won't require additional explicit delete RPC from clients. However depends on the behaviour we want in other places i.e. for client telemetry our goal is to do minimum compute when a telemetry request is received hence keep the cache. Might be somewhat different for consumers as there we want to save on rebalance, hence we might want if same client reconnects with same membership data. >So, what happens if a client sends a PushTelemetry request after re-establishing an idle connection? The request will be fulfilled and a client instance entry in cache will be created. The following happens: the push telemetry requires 2 things: client instance id and subscription id. If both matches then request can be fulfilled. If client instance is not present in the cache with instance id then one is created, though subscription id checksum is computed with crc32 against matching subscriptions. Hence if same instance id along matching subscription id is used then request will be processed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
