chia7712 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2410220855
@apoorvmittal10 Thanks for the feedback. I have a few questions about this PR—thanks for your patience. > Not neccesarily ghost clients but also the clients which are spawned for really short span and stopped. For example the issue fixed in the PR: https://github.com/apache/kafka/pull/17431 should never be encountered if a Kafka Consumer is not closed just after instantiation. But we have seen applications which does have such workloads i.e. clients are created for a very short span as well. Hence those instances are legit but shall occupy a cache entry till time based eviction happens. I feel this situation is similar to the consumer membership issue. What do you think about using RPC-level cleanup by sending a `DeleteTelemetrySubscriptions` request? On the other hand, should we also remove consumer members using this connection listener? The connection-level cleanup has the advantage of handling cases where the client can't send a request to leave. However, on the client side, idle connections can be validly removed, and the default idle timeout is 5 minutes, which is shorter than the TTL for telemetry. So, what happens if a client sends a `PushTelemetry` request after re-establishing an idle connection? > But do we want to have additional compute and tracking for number of requests as well in the cache? I think that will be extra and not required when our goal is to get rid of instances which will never send the telemetry data again i.e. their connections are not disconnected. yes, you are right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
