apoorvmittal10 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2410485313
>So, I'm wondering—will terminating still work if this PR removes the client instance on disconnection? Though terminating is good enough to not accept further push telemetry calls from same client but if we remove the instance from cache on `terminating` flag then it will open us for attacks with rogue clients which can send telemetry push request with terminating flag as true and we will skip push time based throttling for this special push request. Hence it would be better to keep these 2 semantics separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
