chia7712 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2410535536
> Though terminating is good enough to not accept further push telemetry calls from same client but if we remove the instance from cache on terminating flag That's what we discussed on [KAFKA-17760](https://issues.apache.org/jira/browse/KAFKA-17760), but my new question is regarding the PR description: 'This PR adds the capability to evict client instances from the cache when the connection from the client is dropped.' A normal client that is closing will send a request to set terminating=true and then close the connection, which results in the client instance being evicted from the cache. This seems like a kind of two-phase close: the first phase protects against rogue clients by setting terminating=true, and the second phase ensures the cache is protected from overloading. Is that correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
