apoorvmittal10 commented on code in PR #17474:
URL: https://github.com/apache/kafka/pull/17474#discussion_r1801147606
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -114,13 +117,15 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlugin, int clie
this.subscriptionMap = new ConcurrentHashMap<>();
this.subscriptionUpdateVersion = new AtomicInteger(0);
this.clientInstanceCache = new SynchronizedCache<>(new
LRUCache<>(CACHE_MAX_SIZE));
+ this.clientConnectionIdMap = new ConcurrentHashMap<>();
this.expirationTimer = new
SystemTimerReaper(CLIENT_METRICS_REAPER_THREAD_NAME, new
SystemTimer("client-metrics"));
this.clientTelemetryMaxBytes = clientTelemetryMaxBytes;
this.time = time;
this.cacheExpiryMs = cacheExpiryMs;
this.lastCacheErrorLogMs = new AtomicLong(0);
this.metrics = metrics;
this.clientMetricsStats = new ClientMetricsStats();
+ this.connectionDisconnectListener = new
ClientConnectionDisconnectListener(clientInstanceCache, clientConnectionIdMap,
clientMetricsStats);
Review Comment:
Agree, moved the class to non-static and removed these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
