cadonna commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2122841093
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -1230,17 +1219,6 @@ public boolean paranoidFileChecks() {
return columnFamilyOptions.paranoidFileChecks();
}
- @Override
- public Options setMaxWriteBufferNumberToMaintain(final int
maxWriteBufferNumberToMaintain) {
-
columnFamilyOptions.setMaxWriteBufferNumberToMaintain(maxWriteBufferNumberToMaintain);
- return this;
- }
-
- @Override
- public int maxWriteBufferNumberToMaintain() {
- return columnFamilyOptions.maxWriteBufferNumberToMaintain();
- }
-
Review Comment:
Same here.
But here it is even a bit more complicated. It seems that the option that
replaces this option (`max_write_buffer_size_to_maintain`) does not exist in
the Java API. That means, we cannot state in the warn message to use the other
option instead. Could you please research why
`max_write_buffer_size_to_maintain` does not exist in the Java API? RocksDB's
mailing list is a good place to start the research.
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -574,17 +574,6 @@ public long compactionReadaheadSize() {
return dbOptions.compactionReadaheadSize();
}
- @Override
- public Options setRandomAccessMaxBufferSize(final long
randomAccessMaxBufferSize) {
- dbOptions.setRandomAccessMaxBufferSize(randomAccessMaxBufferSize);
- return this;
- }
-
- @Override
- public long randomAccessMaxBufferSize() {
- return dbOptions.randomAccessMaxBufferSize();
- }
-
Review Comment:
Unfortunately, we cannot simply remove these methods since they are kind of
part of the public API. Could you please deprecate the methods and log a warn
message?
Could you add the link to the PR that removes this option in the warn
message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
