brandboat commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2124381733
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -574,17 +574,6 @@ public long compactionReadaheadSize() {
return dbOptions.compactionReadaheadSize();
}
- @Override
- public Options setRandomAccessMaxBufferSize(final long
randomAccessMaxBufferSize) {
- dbOptions.setRandomAccessMaxBufferSize(randomAccessMaxBufferSize);
- return this;
- }
-
- @Override
- public long randomAccessMaxBufferSize() {
- return dbOptions.randomAccessMaxBufferSize();
- }
-
Review Comment:
I just realized I had pasted the wrong link to the RocksDB commit 🤦. The
original commit was actually reverted and later re-submitted. Here's the
correct one:
https://github.com/facebook/rocksdb/pull/13288/files#diff-1536c1746bb06ab2e37be82324b437afc6b0ee159394d0d2c804532515f5a70a
(I’ve also updated the link in the PR description.)
This option is deprecated in the C++ code but has been removed entirely from
the Java library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
